Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multer support for fastify #941

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

sergio-milu
Copy link
Contributor

This PR implements the functionality discussed in this issue #819

I need some help with the testing though, cause I cannot make test run in my computer @samchon

Thanks :)

Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergio-milu
Copy link
Contributor Author

#819 (comment)

any news here?

@sergio-milu
Copy link
Contributor Author

@samchon any news about this PR? has been 4 months, you asked us for a PR and we opened one, if you will discard this, just told us and we will make a fork cause we need this feature in order to fully migrate to nestia

@samchon
Copy link
Owner

samchon commented Oct 24, 2024

Preparing major update to dependent libraries @samchon/openapi and typia.

After these libraries' major updates, nestia will also take the major update too, and this PR would be accept at that time.

The next major update may come in a month.

@samchon samchon changed the base branch from master to v4.0 November 27, 2024 02:28
@samchon samchon changed the base branch from v4.0 to feat/multer November 27, 2024 02:41
Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it fails, merge it anyway for detailed debugging.

@samchon samchon merged commit ac6d5a6 into samchon:feat/multer Nov 27, 2024
2 of 4 checks passed
@samchon samchon added the enhancement New feature or request label Nov 27, 2024
samchon added a commit that referenced this pull request Nov 27, 2024
Complement #941: finalize `TypedFormData()` to support `fastify-multer`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants